Upgrade Compute API version and Fix the response of POST response #3053

hyonholee · 2018-05-10T21:04:41Z

Upgrade Compute API version to 2018-04-01 and Fix the response of all POST operation.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

azuresdkciprbot · 2018-05-10T21:10:31Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/compute/resource-manager/readme.md

⚠️

0 new Warnings.(0 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-10T21:10:31Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/compute/resource-manager/readme.md

⚠️

0 new Warnings.(0 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-10T21:16:55Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/compute/resource-manager/readme.md

⚠️

0 new Warnings.(83 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-10T21:16:55Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/compute/resource-manager/readme.md

⚠️

0 new Warnings.(57 total)

❌2 new Errors.(12 total)

Code	Id	Source	Message
DescriptionMustNotBeNodeName	R3011	Link	Description must not match the name of the node it is supposed to describe. Node name:'parameters' Description:'parameters'
XmsExamplesRequired	D5001	Link	Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations.

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-10T21:30:53Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/compute/resource-manager/readme.md

⚠️

0 new Warnings.(57 total)

❌0 new Errors.(11 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-10T21:30:53Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/compute/resource-manager/readme.md

⚠️

0 new Warnings.(83 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

sergey-shandar

@hyonholee please, when creating a new API version, we need two commits. The first one is a copy of the old one, and the second one should contain changes. In this case, reviewers can see the difference. https://github.com/Azure/azure-rest-api-specs/blob/master/.github/CONTRIBUTING.md#filenames-and-folder-structure

… API version update)

sergey-shandar · 2018-05-14T22:52:29Z

@ravbhatnagar new API version for Compute.

azuresdkciprbot · 2018-05-14T22:53:15Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/compute/resource-manager/readme.md

⚠️

0 new Warnings.(57 total)

❌0 new Errors.(11 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-14T22:53:15Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/compute/resource-manager/readme.md

⚠️

0 new Warnings.(83 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

ravbhatnagar · 2018-05-15T06:29:30Z

@hyonholee - is there a response body in the final response with any of these POST operations?If yes, those will need to be modeled. I am guessing not, but just wanted to confirm. Looks fine. @sergey-shandar - feel free to merge based on response to above.

ravbhatnagar · 2018-05-15T06:31:27Z

specification/compute/resource-manager/Microsoft.Compute/stable/2018-04-01/runCommands.json

+          }
+        ],
+        "responses": {
+          "200": {


For all APis, please model a default error response whose schema complies with the error contract as per ARM RPC.

@ravbhatnagar Do you mean adding default response like this? Is it necessary? Or can I add it in another PR later?

azure-rest-api-specs/specification/datamigration/resource-manager/Microsoft.DataMigration/preview/2018-03-15-preview/datamigration.json

Line 71 in 3a3f869

"default": {

sergey-shandar · 2018-05-16T17:48:51Z

specification/compute/resource-manager/readme.md

@@ -151,6 +151,19 @@ directive:
      - TrackedResourceGetOperation

 ```
+### Tag: package-2018-04-2


@hyonholee Is there a reason why it doesn't match API version?

API version: 2018-04-01

Tag: package-2018-04-2

@sergey-shandar Oh, I just set the tag name to "package-2018-04-2" because "package-2018-04" already exists. Could you suggest a better tag name?

@hyonholee Oh, I see. It looks like 2018-04-01/disk.json is shared. In this case, it's breaking changes, right? Do you change service behavior for disk api version 2018-04-01? Since the 2018-04-01 disk is already in stable folder, I would recommend to create a new api version in this case.

… POST operation.

AutorestCI · 2018-05-17T18:46:51Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2710

AutorestCI · 2018-05-17T18:47:36Z

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
AutorestCI/azure-libraries-for-java#2

AutorestCI · 2018-05-17T18:52:42Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2487

AutorestCI · 2018-05-17T18:54:55Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1853

hyonholee · 2018-05-17T22:12:10Z

Note that this PR is required to fix all POST (currently broken) operations with client library and Powershell including the following issues:

Azure/azure-powershell#5956

Azure/azure-powershell#6030

Azure/azure-powershell#5982

azuresdkci assigned sergey-shandar May 10, 2018

azuresdkci requested a review from sergey-shandar May 10, 2018 21:05

hyonholee force-pushed the postfix branch from f4d6a70 to c0622f0 Compare May 10, 2018 21:12

hyonholee force-pushed the postfix branch from c0622f0 to 2126bcd Compare May 10, 2018 21:25

sergey-shandar suggested changes May 14, 2018

View reviewed changes

Copy compute and runCommand specs from 2017-12-01 to 2018-04-01 (with…

f736791

… API version update)

hyonholee force-pushed the postfix branch from 2126bcd to 42a3d8f Compare May 14, 2018 22:48

sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 14, 2018

ravbhatnagar reviewed May 15, 2018

View reviewed changes

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 15, 2018

sergey-shandar suggested changes May 16, 2018

View reviewed changes

sergey-shandar added the potential-sdk-breaking-change label May 17, 2018

Upgrade Compute API version to 2018-04-01 and Fix the response of all…

7014b95

… POST operation.

hyonholee force-pushed the postfix branch from 42a3d8f to 7014b95 Compare May 17, 2018 18:42

AutorestCI mentioned this pull request May 17, 2018

[AutoPR compute/resource-manager] Upgrade Compute API version and Fix the response of POST response Azure/azure-sdk-for-node#2872

Merged

AutorestCI mentioned this pull request May 17, 2018

[AutoPR compute/resource-manager] Upgrade Compute API version and Fix the response of POST response AutorestCI/azure-libraries-for-java#169

Merged

AutorestCI mentioned this pull request May 17, 2018

[AutoPR compute/resource-manager] Upgrade Compute API version and Fix the response of POST response Azure/azure-sdk-for-python#2580

Merged

AutorestCI mentioned this pull request May 17, 2018

[AutoPR compute/resource-manager] Upgrade Compute API version and Fix the response of POST response Azure/azure-sdk-for-go#1854

Merged

sergey-shandar approved these changes May 21, 2018

View reviewed changes

sergey-shandar merged commit c6fea13 into Azure:master May 21, 2018

konrad-jamrozik pushed a commit to dhung-msft/azure-rest-api-specs that referenced this pull request Dec 4, 2023

Update issue templates (Azure#3053)

d9f7ab1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade Compute API version and Fix the response of POST response #3053

Upgrade Compute API version and Fix the response of POST response #3053

hyonholee commented May 10, 2018 •

edited by azuresdkci

Loading

azuresdkciprbot commented May 10, 2018

azuresdkciprbot commented May 10, 2018

azuresdkciprbot commented May 10, 2018

azuresdkciprbot commented May 10, 2018

azuresdkciprbot commented May 10, 2018

azuresdkciprbot commented May 10, 2018

sergey-shandar left a comment •

edited

Loading

sergey-shandar commented May 14, 2018

azuresdkciprbot commented May 14, 2018

azuresdkciprbot commented May 14, 2018

ravbhatnagar commented May 15, 2018

ravbhatnagar May 15, 2018

hyonholee May 15, 2018

sergey-shandar May 16, 2018

hyonholee May 16, 2018

sergey-shandar May 17, 2018

AutorestCI commented May 17, 2018 •

edited

Loading

AutorestCI commented May 17, 2018 •

edited

Loading

AutorestCI commented May 17, 2018 •

edited

Loading

AutorestCI commented May 17, 2018 •

edited

Loading

hyonholee commented May 17, 2018

Upgrade Compute API version and Fix the response of POST response #3053

Upgrade Compute API version and Fix the response of POST response #3053

Conversation

hyonholee commented May 10, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

azuresdkciprbot commented May 10, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

azuresdkciprbot commented May 10, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

azuresdkciprbot commented May 10, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

azuresdkciprbot commented May 10, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

azuresdkciprbot commented May 10, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

azuresdkciprbot commented May 10, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

sergey-shandar left a comment • edited Loading

Choose a reason for hiding this comment

sergey-shandar commented May 14, 2018

azuresdkciprbot commented May 14, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

azuresdkciprbot commented May 14, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

ravbhatnagar commented May 15, 2018

ravbhatnagar May 15, 2018

Choose a reason for hiding this comment

hyonholee May 15, 2018

Choose a reason for hiding this comment

sergey-shandar May 16, 2018

Choose a reason for hiding this comment

hyonholee May 16, 2018

Choose a reason for hiding this comment

sergey-shandar May 17, 2018

Choose a reason for hiding this comment

AutorestCI commented May 17, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented May 17, 2018 • edited Loading

Automation for azure-libraries-for-java

AutorestCI commented May 17, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented May 17, 2018 • edited Loading

Automation for azure-sdk-for-go

hyonholee commented May 17, 2018

hyonholee commented May 10, 2018 •

edited by azuresdkci

Loading

sergey-shandar left a comment •

edited

Loading

AutorestCI commented May 17, 2018 •

edited

Loading

AutorestCI commented May 17, 2018 •

edited

Loading

AutorestCI commented May 17, 2018 •

edited

Loading

AutorestCI commented May 17, 2018 •

edited

Loading